Added 'uploader_id' setting for gmusicapi login #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this gmusicapi issue when trying to run gmpydl:
simon-weber/gmusicapi#408
The solution was to manually specify the uploader_id parameter for the Musicmanager.login() call. I added this parameter as a setting in the config file so it can be manually specified like this:
uploader_id 01:23:45:67:89:ABAs per the gmusicapi documentation, the uploader_id should be specified as an uppercase, colon-separated MAC address - typically this would be the local host's MAC address incremented by one.
I hope you find this PR useful.