Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cookie support #28

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Set cookie support #28

merged 1 commit into from
Apr 5, 2020

Conversation

hopsoft
Copy link
Contributor

@hopsoft hopsoft commented Mar 5, 2020

No description provided.

@hopsoft hopsoft changed the title [WIP] Set cookie support Set cookie support Apr 5, 2020
@hopsoft hopsoft merged commit fd1f8d9 into master Apr 5, 2020
@hopsoft hopsoft deleted the hopsoft/cookies branch April 5, 2020 15:58
@jonathan-s
Copy link

If I were a user of the set_cookie method in ruby. I'd prefer the method to have the signature `

set_cookie(key, value, expires=None, max_age=None)

That way you don't need to remember how the cookie should be formatted.

@leastbad leastbad mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopsoft @jonathan-s