Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/delete clusterpool #53

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Conversation

itdove
Copy link
Contributor

@itdove itdove commented Jul 20, 2021

#38
Signed-off-by: Dominique Vernier [email protected]

Signed-off-by: Dominique Vernier <[email protected]>
@itdove
Copy link
Contributor Author

itdove commented Jul 20, 2021

/hold

Signed-off-by: Dominique Vernier <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@gurnben gurnben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gurnben, itdove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itdove
Copy link
Contributor Author

itdove commented Jul 20, 2021

/unhold

@openshift-merge-robot openshift-merge-robot merged commit ec0b00e into stolostron:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants