Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Should prompt users in nuke.sh for confirmation before the script proceeds #188

Open
drkho opened this issue May 20, 2021 · 0 comments
Labels
deploy specific to this repository... does not imply product specific issues enhancement New feature or request

Comments

@drkho
Copy link

drkho commented May 20, 2021

Describe the bug
In nuke.sh, there should be a prompt(like the one in uninstall.sh) added to give users a chance to confirm before proceeding to clean up...esp nuke is a destructive script like uninstall.sh

To Reproduce
Steps to reproduce the behavior:

  1. Run ./nuke.sh
  2. No prompt and just proceed

Expected behavior
Added a prompt (from uninstall.sh)

echo "***"
printf "\n"
echo "This script will destroy Open Cluster Management from the current OpenShift target cluster:"
printf "\n"
oc cluster-info | head -n 1 | awk '{print $NF}'
printf "\n"
echo "If you would like to proceed with cleanup, type: DESTROY"
read -r DESTROY_YES
if [ "${DESTROY_YES}" != "DESTROY" ]; then
  echo "You must type DESTROY to clean up the Hive deployed clusters"
  exit 1
fi

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: all applicable
  • Browser all applicable
  • Snapshot all applicable

Additional context
Add any other context about the problem here.

@drkho drkho added bug Something isn't working deploy specific to this repository... does not imply product specific issues labels May 20, 2021
@drkho drkho added enhancement New feature or request and removed bug Something isn't working labels May 20, 2021
@drkho drkho changed the title [BUG][DEPLOY] Should prompt users in nuke.sh for confirmation before the script proceeds [FEATURE] Should prompt users in nuke.sh for confirmation before the script proceeds May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy specific to this repository... does not imply product specific issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants