fix: await interactions rule scope.

[zhyd1997]

Issue: #47

What Changed

Checklist

Check the ones applicable to your change:

• Ran yarn update-all
• Tests are updated
• Documentation is updated

Change Type

Indicate the type of change your pull request is:

• maintenance
• documentation
• patch
• minor
• major

[yannbf]

Hey @zhyd1997 thanks a lot for your contribution! I added a couple comments.

[yannbf]

This check will be true if the user has any random import from @storybook/* such as:

import { actions } from '@storybook/addon-actions'
import { Meta } from '@storybook/react'
import { expect } from '@storybook/jest'

while this is the import that should matter.

import { userEvent } from '@storybook/testing-library'

That is, for the userEvent case in particular. It's still possible to have play functions that do not use @storybook/testing-library but use expect from @storybook/jest instead

[yannbf]

Here are a couple more examples:

// if userEvent is imported from here, then it should provide an error message
import { userEvent } from '@storybook/testing-library'

// if userEvent is imported from somewhere else, it should not
import { userEvent } from '../utils'

Another example that the plugin should not provide an error message:

MyStory.play = async () => {
  const userEvent = { test: () => {} }
  // should not complain
  userEvent.test()
}

And another example that the plugin should provide an error message:

import { expect } from '@storybook/jest'
MyStory.play = async ({ args }) => {
  // should complain
  expect(args.onClick).toHaveBeenCalled()
}

[zhyd1997]

still working on case 2...

[zhyd1997]

Done c5ed780

[zhyd1997]

@yannbf @ndelangen

Thanks for the quick code review, give me some more time to update the PR.

[ndelangen]

Is this ready for review again?

If so, @yannbf and me can take a look again? 🙏
Thank you for the hard work @zhyd1997 !

[zhyd1997]

@ndelangen

Yes, it's ready for review again.
Sorry for that! 🙏🏿

[yannbf]

Thank you so much once again @zhyd1997 ! Sorry it took some time, but I'm getting this in now!

[github-actions]

🚀 PR was released in v0.6.6 🚀