Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-uninstalled-addons): add option for a custom package.json location #102

Conversation

andrelas1
Copy link
Contributor

@andrelas1 andrelas1 commented Jul 24, 2022

Issue: #101

What Changed

Checklist

Check the ones applicable to your change:

  • Ran yarn update-all
  • Tests are updated
  • Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major

Release Notes

feat(no-uninstalled-addons): add option for a custom package.json location (#102)

Features

The no-uninstalled-addons feature had an issue where it was assuming that the package.json of which the addon dependencies are installed was always in the root, and for some projects that was not true. For that scenario, the rule now provides an option to specify the exact path of the package.json:

module.exports = {
  rules: {
    'storybook/no-uninstalled-addons': ['error', { packageJsonLocation: './custom-folder/package.json' }],
  },
}

@yannbf yannbf added the patch Increment the patch version when merged label Aug 2, 2022
@yannbf yannbf changed the title feat(no-uninstalled-addons): add option for a custom package.json loc… feat(no-uninstalled-addons): add option for a custom package.json location Aug 2, 2022
@yannbf
Copy link
Member

yannbf commented Aug 2, 2022

Thanks a ton @andrelas1 for your efforts, this looks fantastic!

@yannbf yannbf merged commit 85d8d02 into storybookjs:main Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🚀 PR was released in v0.6.2 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants