Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vue3 e2e tests #16254

Closed
shilman opened this issue Oct 6, 2021 · 1 comment
Closed

Fix vue3 e2e tests #16254

shilman opened this issue Oct 6, 2021 · 1 comment
Assignees
@gaetanmaisse
Labels
maintenance User-facing maintenance tasks vue3

Comments

@shilman
Copy link
Member

shilman commented Oct 6, 2021 •
edited by gaetanmaisse
Loading

Succeeds:

npx sb@next repro -t vue3 vue3-normal

Fails:

npx sb@next repro -t vue3 --e2e vue3-e2e

Example in CI: https://app.circleci.com/pipelines/github/storybookjs/storybook/20996/workflows/7b404687-4379-4ced-93f6-879b8a3f16c1/jobs/341370
@shilman shilman added maintenance User-facing maintenance tasks vue3 labels Oct 6, 2021
@gaetanmaisse gaetanmaisse mentioned this issue Oct 6, 2021
Merged
@shilman
Copy link
Member Author

shilman commented Oct 27, 2021

Jeepers creepers!! I just released https:/storybookjs/storybook/releases/tag/v6.4.0-beta.21 containing PR #16263 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaetanmaisse gaetanmaisse

Labels
maintenance User-facing maintenance tasks vue3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shilman @gaetanmaisse