Core: Ensure we don't reset WebPreview
if calling start()
in v7 mode
#16475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16455
The problem was that when you import from
@storybook/angular
it callsstart()
(as do all other frameworks), which created an old, non-v7StoryStore
and assigned it to__STORYBOOK_STORY_STORE__
, then awaited aconfigure()
call (that never came....)What I did
start()
is a no-op in v7 modeQuestions
Should we make some of that API work (i.e.
api.raw()
etc?)How to test
See example in issue.