Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions: move step debugger behind feature flag #16481

Merged
merged 9 commits into from
Oct 27, 2021

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Oct 26, 2021

Issue: #16471

What I did

As title says. Behind this feature flag:

// main.js
module.exports = {
  features: {
    interactionsDebugger: true
  }
}

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation? // To be done

If your answer is yes to any of these, please make sure to include it in your PR.

┆Issue is synchronized with this Asana task by Unito

@nx-cloud
Copy link

nx-cloud bot commented Oct 26, 2021

Nx Cloud Report

CI ran the following commands for commit 65d5f62. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

lib/core-common/src/types.ts Outdated Show resolved Hide resolved
@MichaelArestad
Copy link
Contributor

This looks great. Thank you for adding the Panel stories!

@yannbf
Copy link
Member Author

yannbf commented Oct 26, 2021

@shilman I added the do not merge label in case we want to add documentation about this, however I did no see docs for the other flags. If you feel like we should add let me know where, otherwise feel free to remove the label and merge this (after @MichaelArestad approves it)!

@tmeasday tmeasday removed this from the 6.4 interaction testing milestone Oct 27, 2021
@yannbf yannbf merged commit e260ec5 into next Oct 27, 2021
@yannbf yannbf deleted the feature/interactions-feature-flag branch October 27, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants