Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-info: Improve accessibility by contrast #4698

Merged
merged 5 commits into from
Nov 5, 2018
Merged

Addon-info: Improve accessibility by contrast #4698

merged 5 commits into from
Nov 5, 2018

Conversation

hipstersmoothie
Copy link
Contributor

@hipstersmoothie hipstersmoothie commented Nov 2, 2018

Issue: #4224

What I did

Change the font color to be accessible

How to test

Is this testable with Jest or Chromatic screenshots? Yes
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@Hypnosphi Hypnosphi changed the title Update Node.js Update components/Node.js in info addon Nov 3, 2018
@Hypnosphi
Copy link
Member

Hypnosphi commented Nov 3, 2018

Please run yarn test --core --update to update test snapshots

UPD: nevermind, as I see it's a PR created from UI, so I'll do it myself

@hipstersmoothie
Copy link
Contributor Author

@Hypnosphi is there anything else you want me to do for thiis PR?

@Hypnosphi
Copy link
Member

No thanks

@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #4698 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4698   +/-   ##
=======================================
  Coverage   35.59%   35.59%           
=======================================
  Files         557      557           
  Lines        6732     6732           
  Branches      884      884           
=======================================
  Hits         2396     2396           
  Misses       3876     3876           
  Partials      460      460
Impacted Files Coverage Δ
addons/info/src/components/Node.js 93.1% <ø> (ø) ⬆️
addons/info/src/components/PropVal.js 87.03% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729bc9c...3b90fa0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants