Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Fixes around license derivatives #112

Merged
merged 7 commits into from
Feb 17, 2024
Merged

Fixes around license derivatives #112

merged 7 commits into from
Feb 17, 2024

Conversation

Ramarti
Copy link
Contributor

@Ramarti Ramarti commented Feb 17, 2024

  • Derivatives: false -> add check on linking (should fail)
  • Fixed the check for no derivatives of derivatives on mint (derivativesReciprocal: false)
  • Removed unnecesary interface checks to save gas
  • Fixed verifyLink, in some states all the conditions we returned too soon

LeoHChen
LeoHChen reviewed Feb 17, 2024
View reviewed changes
Copy link
Member

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 1st pass, seems okay in general

@LeoHChen LeoHChen merged commit 17f8e70 into storyprotocol:main Feb 17, 2024
1 check passed
kingster-will referenced this pull request in kingster-will/protocol-core-v1-dev Mar 19, 2024
@Ramarti @LeoHChen @kingster-will
Fixes around license derivatives (storyprotocol#112)
9df71c5 
---------

Co-authored-by: Leo Chen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeoHChen LeoHChen LeoHChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ramarti @LeoHChen