Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

add upfront minting fee #113

Merged
merged 12 commits into from
Feb 17, 2024
Merged

add upfront minting fee #113

merged 12 commits into from
Feb 17, 2024

Conversation

Spablob
Copy link
Contributor

@Spablob Spablob commented Feb 17, 2024 •
edited
Loading

Adjusts on licensing and royalty side to add the upfront minting license payment

@Spablob Spablob marked this pull request as ready for review February 17, 2024 10:09
LeoHChen
LeoHChen reviewed Feb 17, 2024
View reviewed changes
Copy link
Member

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, some simple questions needs clarification.

@LeoHChen LeoHChen merged commit 7ebe938 into storyprotocol:main Feb 17, 2024
1 check passed
@jdubpark jdubpark mentioned this pull request Feb 17, 2024
Merged
kingster-will referenced this pull request in kingster-will/protocol-core-v1-dev Mar 19, 2024
@Spablob @Ramarti @kingster-will
add upfront minting fee (storyprotocol#113)
3daf86c 
* royalty module adjustments

* license related adjustments

* uml related adjustments

* script adjustments

* integration and mocks adjustments

* prevent NC minting fee

---------

Co-authored-by: Raul <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeoHChen LeoHChen LeoHChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Spablob @LeoHChen @Ramarti