This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Fix Licensing Minting Payment to Account for Mint Amount #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdubpark
requested review from
Spablob and
a team
and removed request for
Spablob
Fix Licensing Minting Payment to Account for Mint Amount
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
LeoHChen
reviewed
Feb 23, 2024
LeoHChen
approved these changes
Feb 23, 2024
kingster-will
referenced
this pull request
in kingster-will/protocol-core-v1-dev
Mar 19, 2024
…ol#129) * fix: mint payment based on amount minted * feat: mint license input validations * test: add license minting fee test in integration * test: fix helper policy params & update test for mint amounts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we ran tests with MintPaymentPolicyFrameworkManager, but it was removed with changes in the Licensing Module. We missed the multiplication for the mint payment amount and had no test against it. This is a quick fix with a working test added.
Thank you @Spablob for finding this bug!