Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Test: Restrictions on Minting Licenses #57

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

jdubpark
Copy link
Contributor

@jdubpark jdubpark commented Feb 1, 2024

Following #47 from @Ramarti, this PR enhances the previous PR with the latest main tracking.

Based on @Ramarti's note:
Previously, we assumed a policy must be set for an IPAccount to mint out licenses. However, we now consider two cases:

  • If IPAccount has a policy set, ANYONE can mint a license after conditional ParameterFramework checks.
  • If IPAccount doesn't have a policy set, the owner or delegate of the IPAccount is permitted to mint a license with an unattached policy. No other entity can mint a license.

Merging this will close #47 as well.

Copy link
Contributor

@Ramarti Ramarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdubpark jdubpark merged commit b49f191 into storyprotocol:main Feb 1, 2024
1 check passed
@LeoHChen
Copy link
Member

LeoHChen commented Feb 1, 2024

  • If IPAccount doesn't have a policy set, the owner or delegate of the IPAccount is permitted to mint a license with an unattached policy. No other entity can mint a license.

I thought we have a default "on-chain UML" as the default policy for everyone. So there should be a policy attached to every IPAsset. @Ramarti @jdubpark

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants