Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract error codes construction #919

Closed
mulkieran opened this issue Oct 13, 2022 · 1 comment · Fixed by #930
Closed

Abstract error codes construction #919

mulkieran opened this issue Oct 13, 2022 · 1 comment · Fixed by #930
Assignees

Comments

@mulkieran
Copy link
Member

Presently we have three prefixes, "I", "E", "W" with the usual interpretations. But we don't abstract them, we just include them in the error string.

We need to define some enum probably, with these three constants, and then we need to use these constants when forming the error string.

We might also want to define constants for the second portion of the string, which is a two character chunk which has some relation to the problem. For example, in a pool, "DS" stands for "device size".

@mulkieran mulkieran self-assigned this Oct 13, 2022
@mulkieran
Copy link
Member Author

#906 has added just enough error code constructions to make this effort worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant