Remove useless omitempty

[jiangpengcheng]

Fixes #383

Motivation

Remove omitempty if it's required

Modifications

Verifying this change

• Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below.

Need to update docs?

• doc-required

  (If you need help on updating docs, create a doc issue)

• no-need-doc

  tiny fix

• doc

  (If this PR contains doc changes)

[jiangpengcheng]

it looks like only when // +kubebuilder:validation:Required is specified and no omitempty is added, the field would be marked as required

refers:

1. +kubebuilder:validation:Required take precedence over omitempty kubernetes-sigs/controller-tools#642
2. +kubebuilder:validation:Required marker not working kubernetes-sigs/controller-tools#599

[jiangpengcheng]

I think spec.name is not required

[freeznet]

for Function CRD it should be non-required since it is duplicated with .metadata.name, but for Mesh CRD, which reuses FunctionSpec and uses the .spec.name in Mesh controller as well.

[tpiperatgod]

lgtm

[jiangpengcheng]

seems need to update the CRD content in charts/

[tpiperatgod]

seems need to update the CRD content in charts/

we may then need a function to generate them automatically 🤣

[freeznet]

we may then need a function to generate them automatically 🤣

@tpiperatgod Seems we need to change helm-crds in Makefile as well.

[jiangpengcheng]

since #409 is merged, do we need to update the generated YAML in this PR and also other PRs which make changes to the CRD content?
@freeznet @tpiperatgod HDYT?

[freeznet]

@jiangpengcheng yes, please update the CRDs with this PR.