Add assertion for NotErrorAs #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palsivertsen
force-pushed
the
not-error-as
branch
from
bb0fb09
to
5a5b06e
Compare
|
+1 for this PR. |
dolmen
added
enhancement
pkg-assert
mmorel-35
reviewed
Sep 19, 2024
assert/assertion_forward.go
Outdated
| } | ||
|
|
||
| // NotErrorAsf asserts that at none of the errors in err's chain matches target. | ||
| // This is the inverse of the ErrorAs function. |
There was a problem hiding this comment.
Suggested change
| // This is the inverse of the ErrorAs function. | |
| // This is the opposite of the ErrorAs function. |
There was a problem hiding this comment.
None of the other negative assertions refer to their counterpart in this way. The description of their function is sufficient. Just drop this line.
|
Hi @dolmen , |
|
Commented on @mmorel-35 's review, I'm happy merging once resolved. This also needs a re-base. This also needs coordinating with #1646. if @palsivertsen is no longer around then feel free to open a new PR based on their commit @mmorel-35. |
palsivertsen
force-pushed
the
not-error-as
branch
from
5849ec5
to
90d5d50
Compare
palsivertsen
pushed a commit
to palsivertsen/testify
that referenced
this pull request
Oct 4, 2024
Review feedback: stretchr#1129 (comment)
palsivertsen
pushed a commit
to palsivertsen/testify
that referenced
this pull request
Oct 4, 2024
Review feedback: stretchr#1129 (comment)
palsivertsen
force-pushed
the
not-error-as
branch
from
90d5d50
to
1d575dd
Compare
|
@brackendawson Rebased on master and addressed review feedback. Also fixed a typo. |
brackendawson
requested changes
Oct 4, 2024
assert/assertions.go
Outdated
| @@ -2149,6 +2149,23 @@ func ErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{ | |||
| ), msgAndArgs...) | |||
| } | |||
|
|
|||
| // NotErrorAs asserts that none of the errors in err's chain matches target. | |||
There was a problem hiding this comment.
Suggested change
| // NotErrorAs asserts that none of the errors in err's chain matches target. | |
| // NotErrorAs asserts that none of the errors in err's chain matches target, but if so, sets target to that error value. |
palsivertsen
pushed a commit
to palsivertsen/testify
that referenced
this pull request
Oct 4, 2024
The library already had assertions for `ErrorIs`, `NotErrorIs` and `ErrorAs`. This commit adds the `NotErrorAs` assertion which is the inverse of `ErrorAs`.
Checks that the assertion result matches what's set in `testing.T`.
Review feedback: stretchr#1129 (comment)
palsivertsen
force-pushed
the
not-error-as
branch
from
b1df1ea
to
f844b26
Compare
brackendawson
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The library had implementations for ErrorIs, ErrorAs and NotErrorIs but
was missing a NotErrorAs implementation. This PR adds a NotErrorAs
function, which is the inverse of the ErrorAs function.
Changes
NotErrorAsfunction and testTestErrorIs,TestNotErrorIsandTestErrorAs) by comparing assertion result andtesting.Tflag.NotErrorIsfunctionMotivation
There's already an inverse of
ErrorIs,ErrorAsshould have an inverse as well.Related issues
Closes #1066