Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jacobian of BC_HeatFlux_Wall in TurbSASolver #2342

Open
Wang-Lancelot opened this issue Aug 14, 2024 · 4 comments
Open

Jacobian of BC_HeatFlux_Wall in TurbSASolver #2342

Wang-Lancelot opened this issue Aug 14, 2024 · 4 comments
Labels

Comments

@Wang-Lancelot
Copy link

Wang-Lancelot commented Aug 14, 2024

In CTurbSASolver.cpp line 496, the Jacobian_i = (laminar_viscosity*Area)/(0.03*Roughness_Height*sigma);

Should it be Jacobian_i = (laminar_viscosity /density *Area)/(0.03*Roughness_Height*sigma); ?

@pcarruscag
Copy link
Member

Seems that way, can you open a pull request to fix it?

@Wang-Lancelot
Copy link
Author

Sure, I will open one later.

Seems that way, can you open a pull request to fix it?

@vkrm1612
Copy link

Hey,
I want to make this change...!

@Wang-Lancelot
Copy link
Author

Hey, I want to make this change...!

Sure, if you are willing to, please make it. Thank you so much for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants