Variant item selection/deselection #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 5, 2024 13:26
we select a few variant items -> chips are shown in the text. When we switch the annotation tab i.e to 'Motifs' then the chips should not be shown in the text anymore
for each variant item we deselect, we remove the 'witness chip' from the text
paulpestov
reviewed
Aug 8, 2024
src/utils/annotations.js
Outdated
| @@ -233,6 +233,71 @@ export function removeIcon(annotation) { | |||
| } | |||
| } | |||
|
|
|||
| export function addWitness(selector, witness, witnessColor, variantItemsSelected, variantItemsColors) { | |||
| const targetHtmlEl = document.querySelector(selector) | |||
There was a problem hiding this comment.
Avoid using document at root of your DOM manipulations. Try to use at least #text-content. Actually we need to find a way to select from the right text panel. But this is yet to come.
added 5 commits
August 8, 2024 10:36
paulpestov
reviewed
Aug 8, 2024
paulpestov
approved these changes
Aug 8, 2024
paulpestov
pushed a commit
that referenced
this pull request
Aug 21, 2024
* feat: style better the "chip" * feat: add border color for each of the different ‘chips’ * feat: split up the variant items * feat: select only one variant item * feat: select a variant item and toggle accordingly * feat: add the 'witnesses chips' in the text * feat: remove 'witnesses chips' in other tabs we select a few variant items -> chips are shown in the text. When we switch the annotation tab i.e to 'Motifs' then the chips should not be shown in the text anymore * feat: remove the witnesses in the text for each variant item we deselect, we remove the 'witness chip' from the text * chore: change the icon names in the config * style: fix linting * refactor: remove 'isText' from AnnotationVariantItem * refactor: use watch to initialize 'variantItemsSelection' * refactor: access 'target' from the text Panel html element * refactor: keep the same text of witness served from the backend * style: minor * refactor: access the witnesses span from the text panel html el --------- Co-authored-by: malkja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add the following features: