Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting/Deselecting an annotated text #460

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Conversation

orlinmalkja
Copy link
Contributor

In this PR I address the following features:

  • integrate together the functioning of selecting/deselecting a variant item in the Annotations panel and selecting/deselecting the annotated text in the Text Panel
  • selecting an annotated text -> the witnesses 'chips' of that variant object should be shown in the text
  • deselecting an annotated text -> remove the witnesses 'chips' from the text
  • deal with the coloring of the witnesses chips

@orlinmalkja orlinmalkja self-assigned this Aug 11, 2024
@orlinmalkja orlinmalkja merged commit 5d451cb into main-variants Aug 12, 2024
2 checks passed
@orlinmalkja orlinmalkja deleted the selecting-text branch August 12, 2024 11:08
paulpestov pushed a commit that referenced this pull request Aug 21, 2024
* feat: create an initial version of 'selecting text'

* refactor: commented out the first approach for this task

* refactor: remove the first method of 'select text'

* feat: deal with coloring of the witnesses chip

* feat: show witnesses when clicking on text

* feat: remove witnesses chips when deselecting text

* chore: minor

* refactor: minor

* docs: reason why we use pickVariantItemsSelection()

* style: rename initVariantItemsSelection variable

---------

Co-authored-by: malkja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants