Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined cli flags override config #62

Merged
merged 2 commits into from
Nov 15, 2016
Merged

Fix undefined cli flags override config #62

merged 2 commits into from
Nov 15, 2016

Conversation

giuseppeg
Copy link
Member

When cli flags are not passed their value is undefined and they override the config file options.
This branch fixes this behaviour.

Fixes #54

@simonsmith
Copy link
Member

Looks good. Just need a CHANGELOG update and for some reason your commit isn't associated with your user:

screen shot 2016-11-13 at 14 46 57

@giuseppeg
Copy link
Member Author

@simonsmith can you restart the appveyor build?

@simonsmith
Copy link
Member

Restarted. I think I can add you to the Appveyor project if you let me know preferred email.

@giuseppeg
Copy link
Member Author

thanks @simonsmith ! can I merge this?

@simonsmith
Copy link
Member

Yup

@giuseppeg giuseppeg merged commit e465938 into master Nov 15, 2016
@giuseppeg giuseppeg deleted the fix/cli-options-override branch November 15, 2016 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simonsmith simonsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI options should override config file
3 participants
@giuseppeg @simonsmith @danalloway