Use const generics. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Absolutely, yes. The reason I didn't go for it yet is because of the limited compile-time arithmetic support for const generics. |
|
Are you ok with the PR as is, or would you prefer some changes? Thanks. |
|
ping? |
|
Heya, apologies for the delay. Didn't have the time to get into it in depth yet. |
|
@ahmedcharles Thanks for the implementation! I adjusted it a bit to get rid of the redundant row/column counts. Will merge in a bit. |
|
I should've mentioned that I had a commit to remove those parameters, I didn't submit it because I wanted it to be obvious that the asserts were correct. :) |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't remove the fields, it uses them to verify that all of the values are right through debug_asserts. I have more PRs that take this approach further.
The only issue with this is that it doesn't work with the trait, because
Self::Targetisn't the same time for each of the various functions.Anyways, is this a direction that you're open to? Thanks.