-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signInWithPassword ignores options.data instead of writing it to user_metadata #811
Comments
Uhm... any chance this will be resolved at some point? Or are we better off using the REST API directly? |
Or would a pull request fixing this be merged? |
Is this an issue with the type definition, it seems like the data object exists on the second type with the phone number
|
@mb21 @JJAHMEDAMER apologies for the oversight, this is an issue with the type definition and i've just put up a PR to fix this: #848 |
@kangmingtay thanks for taking a look at this! My preferred outcome would of course have been that the data is written to |
## What kind of change does this PR introduce? * Fixes #811
@kangmingtay and @hf you're working for supabase, right? Could you please answer my question(s) about whether a PR would be accepted to save |
@mb21 Hi, may you share your solution? |
@Giasinit I haven't actually coded anything and am not going to unless somebody from supabase gives an indication that it might be merged. But as unresponsive as they have been it's unclear to me whether supabase auth is actively developed. Therefore we're looking to switch to https://lucia-auth.com |
Describe the bug
signInWithPassword ignores the
options.data
field, even though the TypeScript definitions list options.data as a supported field – at least in the case where you provide a phone number.To Reproduce
Call
supabase.auth.signInWithPassword({ phone, password, options: { data } })
.Expected behavior
options.data
should be persisted inauth.users.user_metadata
.Ideally, this should also work for the case where you provide
email
instead ofphone
.System information
Additional context
Related question: https:/orgs/supabase/discussions/8873
The text was updated successfully, but these errors were encountered: