-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current session lost when auth function call fails #904
Labels
bug
Something isn't working
Comments
kangmingtay
added a commit
that referenced
this issue
Jun 7, 2024
## What kind of change does this PR introduce? * Replaces #854 * Fixes #853, #904 * We don't need to remove the existing session prematurely. This causes some issues when users want to implement some sort of switch-account functionality since the existing session will always be removed regardless of whether the signup / sign-in attempt succeeds. * It's safe to remove `_removeSession` since calling `_saveSession` multiple times will just replace the existing session
This was closed with #915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Describe the bug
Currently, the client logic calls
_removeSession
to clear the session when doing an auth call. If the call fails, the existing session is never restored and is lost, effectively disconnecting the user session.To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Expected behavior
The existing client session is kept in the event of a fail.
System information
The text was updated successfully, but these errors were encountered: