feat: add _acquireLock and navigatorLock #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
commented
Jul 15, 2023
J0
approved these changes
Jul 18, 2023
|
🎉 This PR is included in version 2.44.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
hf
added a commit
that referenced
this pull request
Sep 20, 2023
Given the changes introduced in #736, some of the MFA methods were exempt from acquiring the lock. However, this appears to have been a bad idea, especially around `_getAuthenticatedAssuranceLevel` which is used while the user is authenticated. This PR adds the locks in the correct places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of: #734
Adds an experimental
lockoption. This is used internally within_acquireLock()which can be used to acquire a global exclusive lock when using the client. It can prevent issues with concurrent access to local storage.navigatorLockis an experimental lock that can be used to test the library before officially designating it (or an alternative) as the default global exclusive locking mechanism. It will be rolled out on supabase.com/dashboard over time as we grow our confidence in the library.