Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method for anonymous sign-in #858

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Mar 4, 2024

What kind of change does this PR introduce?

@kangmingtay kangmingtay force-pushed the km/feat-add-anonymous-sign-in branch from 265c065 to 889a462 Compare March 4, 2024 09:02
@kangmingtay kangmingtay requested a review from a team March 4, 2024 09:05
src/lib/types.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The world will be a better place!

@kangmingtay kangmingtay merged commit e8a1fc9 into master Mar 6, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/feat-add-anonymous-sign-in branch March 6, 2024 07:10
kangmingtay pushed a commit that referenced this pull request Mar 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.63.0](v2.62.2...v2.63.0)
(2024-03-26)


### Features

* add method for anonymous sign-in
([#858](#858))
([e8a1fc9](e8a1fc9))
* add support for error codes
([#855](#855))
([99821f4](99821f4))
* explicit `cache: no-store` in fetch
([#847](#847))
([034bee0](034bee0))
* warn use of `getSession()` when `isServer` on storage
([#846](#846))
([9ea94fe](9ea94fe))


### Bug Fixes

* refactor all pkce code into a single method
([#860](#860))
([860bffc](860bffc))
* remove data type
([#848](#848))
([15c7c82](15c7c82))

---
This PR was generated with [Release
Please](https:/googleapis/release-please). See
[documentation](https:/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@senadir
Copy link

senadir commented Mar 31, 2024

I tried using this and I'm getting a 422 Password is required error, not sure what I'm missing, nothing in the request or the PR above seems to indicate is_anonymous is being passed to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants