Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify how to use pg_net on a different database #99

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

soedirgo
Copy link
Member

@soedirgo soedirgo commented Aug 8, 2023

No description provided.

@soedirgo soedirgo changed the title Update README.md clarify how to use pg_net on a different database Aug 8, 2023
@soedirgo
Copy link
Member Author

soedirgo commented Aug 8, 2023

why is this flaky :(

@TheOtherBrian1
Copy link
Contributor

TheOtherBrian1 commented Aug 8, 2023

The tests make requests that timeout before a response can be returned. The default max time for any request is 2 seconds. The endpoint, httpbin, is too slow, so the tests receive a timeout error instead of an expected response.

I tried changing the API endpoint from httpbin to postman's testing API in a pull request some time ago. I was hoping utilizing a more reliable endpoint would solve the issue. However, after Github actions took over an hour to execute the test, I closed my request.

I'm not too familiar with Github actions, but perhaps modifying the testing code it relied on resulted in strange behaviors. Either or, if you can limit the max runtime for the actions, I think you should.

@steve-chavez
Copy link
Member

steve-chavez commented Aug 8, 2023

The endpoint, httpbin, is too slow, so the tests receive a timeout error instead of an expected response.

Will move the tests to our openresty server in another PR

Edit: #102

@soedirgo soedirgo merged commit 02b9941 into master Aug 9, 2023
0 of 8 checks passed
@soedirgo soedirgo deleted the soedirgo-patch-1 branch August 24, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants