Update authentication options in createServerClient #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
reviewed
Sep 4, 2024
| @@ -170,11 +163,11 @@ export function createServerClient< | |||
| ...(options?.cookieOptions?.name | |||
| ? { storageKey: options.cookieOptions.name } | |||
| : null), | |||
| ...options?.auth, | |||
| flowType: "pkce", | |||
There was a problem hiding this comment.
It looks like it'd no longer be possible to override persistSession , autoRefreshToken etc.. with user supplied options after this change. Not sure if we'd want that
Let me know if I've misunderstood the change though.
mariojfduarte
commented
Sep 4, 2024
| flowType: "pkce", | ||
| autoRefreshToken: false, | ||
| detectSessionInUrl: false, | ||
| persistSession: true, | ||
| ...options?.auth, |
There was a problem hiding this comment.
It would, currently is it not possible
There was a problem hiding this comment.
You're right, it would make it configurable. I'm still not sure it'll fix the concern around a service role client though. Let's complete discussing the issue on the thread and circle back to this PR if needed
|
Based on the resolution of #59, I'd suggest closing this PR. Thoughts @mariojfduarte ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
#59
authobject is properly configured withflowType,autoRefreshToken,detectSessionInUrl,persistSession, and any additional options fromoptions.auth.