Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional debug telemetry #566

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Oct 8, 2024

What kind of change does this PR introduce?

Improvement

What is the new behavior?

  • Only enable telemetry in logs when TRACING_MODE=debug|logs - we should turn this off when not needed.
  • Allow to toggle on / off telemetry for upload

@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11235131522

Details

  • 32 of 156 (20.51%) changed or added relevant lines in 4 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 77.895%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/tracing.ts 2 31 6.45%
src/storage/backend/s3.ts 23 118 19.49%
Files with Coverage Reduction New Missed Lines %
src/internal/concurrency/stream.ts 16 15.79%
Totals Coverage Status
Change from base Build 11163447338: -0.5%
Covered Lines: 13854
Relevant Lines: 17647

💛 - Coveralls

@fenos fenos force-pushed the tracing/optional-log-tracing branch from c6b2c6b to 5d6c9cb Compare October 8, 2024 11:31
@fenos fenos force-pushed the tracing/optional-log-tracing branch from 5d6c9cb to 6ad7f50 Compare October 8, 2024 12:11
@fenos fenos merged commit c8f93e5 into master Oct 8, 2024
1 check passed
@fenos fenos deleted the tracing/optional-log-tracing branch October 8, 2024 13:07
Copy link

github-actions bot commented Oct 8, 2024

🎉 This PR is included in version 1.11.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants