Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input component hiding of error icon #311

Open
Ziinc opened this issue Jan 18, 2022 · 7 comments
Open

Input component hiding of error icon #311

Ziinc opened this issue Jan 18, 2022 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ziinc
Copy link

Ziinc commented Jan 18, 2022 •
edited
Loading

Would be great to have a prop to hide the error icon, currently it shows by default, which in some situations (see below) would make the input bar actions area even more cluttered. Currently no way to hide it once the error prop is provided.

image
@Ziinc Ziinc added the enhancement New feature or request label Jan 18, 2022
@MildTomato
Copy link
Contributor

great idea!

@MildTomato MildTomato added the good first issue Good for newcomers label Jan 18, 2022
@FatumaA
Copy link

FatumaA commented Jan 19, 2022

@MildTomato Can I try this one?
Also, shouldn't the error icon be with the error msg instead of within the input component?

@MildTomato
Copy link
Contributor

MildTomato commented Jan 21, 2022 •
edited
Loading

It might be best to avoid changing anything right now in master branch

I'm about to merge a huge change into the alpha branch, so it might be better to work on changes for this on that branch since I think a lot of the actions container has been refactored.

@MildTomato
Copy link
Contributor

@FatumaA I think the best action to take might be to just add a new prop, like hideErrorIcon which would stop the icon appearing altogether when error prop is used.

@FatumaA
Copy link

FatumaA commented Jan 22, 2022

Ok, thanks @MildTomato, I will go ahead and attempt a fix for this then

@FatumaA FatumaA mentioned this issue Jan 22, 2022
Closed
@MildTomato MildTomato reopened this Nov 20, 2023
@FatumaA
Copy link

FatumaA commented Nov 20, 2023

Is this still an issue? I'd be happy to take another look 🤭

@ak708
Copy link

ak708 commented Apr 5, 2024

Is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement/input component hiding of error icon
4 participants
@MildTomato @Ziinc @FatumaA @ak708