Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diamond background is displayed not only on Locked screen but each time the wallet is opened. #3338

Open
onvisions opened this issue Oct 18, 2024 · 0 comments

Comments

@onvisions
Copy link
Collaborator

onvisions commented Oct 18, 2024

1. The diamond animation should be shown as background only when the wallet is locked.

Instead it is displayed for a brief moment each time the user opens the wallet or confirms a transaction on tokaen.org.

It's displayed together with the default small diamond animation for loading.

See the recordings below for reference:

Open wallet:
https:/user-attachments/assets/0df06daf-8e8d-4540-a011-fd220bb81fb8

Each time wallet is opened:
Image

Confirm a transaction:
https:/user-attachments/assets/8b0454e0-cbaf-4f06-9749-076ca6870ba3

Image

Steps to reproduce the behavior:

  1. Set password;
  2. Unlock wallet;
  3. Close wallet without locking it;
  4. Open wallet;
  5. See the Diamond animation and the small diamond preloader displayed each time on opening the wallet extension.

Expected behavior

  1. Diamond background should be displayed only on the Locked screen (with the password fields). The animation should be visible only when user unlocks the wallet with password and not each time the wallet is opened.

.....................................................................................

2. The background is not centered when the extension is scaled within a browser tab.

Steps to reproduce the behavior:

CASE 1

  1. Open tokaen.org and connect wallet;
  2. In case the user's wallet has updated to last release "Set password" for first time is displayed;
  3. Background is misaligned.

CASE 2

  1. Open tokaen.org and connect wallet;
  2. Try to buy or sell a token;
  3. Observe the behavior of confirmation screens.

First time setting the password/Enter password to unlock:
Image

Confirm a transaction:
https:/user-attachments/assets/8b0454e0-cbaf-4f06-9749-076ca6870ba3

Image

Expected behavior
2. The background should be centered and not pixelated with image quality decreased.

Possible reason - wrong alignment when scaling the extension to bigger dimensions within a browser tab.
The graphic resource used is one time PNG the other SVG. SVG should be used everywhere as it scales without losing quality. And it's lower in Mb size at the same time.

Observed on Desktop:

  • OS: Windows 10
  • Browser Chrome
  • Version 129.0.6668.103 (Official Build) (64-bit)
@onvisions onvisions changed the title Diamond background is displayed not only on Lock screen but each time the wallet is opened. Diamond background is displayed not only on Locked screen but each time the wallet is opened. Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant