Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SW-1298] move fungibleTokens from store to composable #2361

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[SW-1298] move fungibleTokens from store to composable #2361

merged 1 commit into from
Oct 26, 2023

Conversation

konradodo
Copy link
Contributor

No description provided.

@konradodo konradodo force-pushed the feat/removing-fungibleTokens-from-store branch 2 times, most recently from 7c6589d to aaff3ae Compare September 26, 2023 12:21
@konradodo konradodo changed the title [SW-1298] move fungiblesTokens from store to composable [SW-1298] move fungibleTokens from store to composable Sep 26, 2023
pstachel
pstachel suggested changes Sep 26, 2023
View reviewed changes
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/protocols/aeternity/components/TransferReview.vue Outdated Show resolved Hide resolved
src/protocols/aeternity/components/TransferSendForm.vue Outdated Show resolved Hide resolved
src/protocols/aeternity/views/TransactionDetails.vue Outdated Show resolved Hide resolved
src/store/plugins/pollAccountInfo.js Outdated Show resolved Hide resolved
tests/unit/getters/get-tx-amount-total.spec.js Outdated Show resolved Hide resolved
peronczyk
peronczyk requested changes Sep 26, 2023
View reviewed changes
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/store/plugins/pollAccountInfo.js Outdated Show resolved Hide resolved
tests/unit/getters/get-tx-amount-total.spec.js Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
@konradodo konradodo force-pushed the feat/removing-fungibleTokens-from-store branch from aaff3ae to 98e1317 Compare September 27, 2023 11:16
@konradodo konradodo force-pushed the feat/removing-fungibleTokens-from-store branch 2 times, most recently from b46000b to c13c1f8 Compare September 28, 2023 09:35
@github-actions
Copy link

Deployed to feat-removing-fungibletokens-from-store.wallet.z52da5wt.xyz, artifacts

peronczyk
peronczyk requested changes Sep 28, 2023
View reviewed changes
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/pollAccountInfo.ts Outdated Show resolved Hide resolved
@konradodo konradodo force-pushed the feat/removing-fungibleTokens-from-store branch from c13c1f8 to 274c462 Compare September 28, 2023 10:31
@konradodo konradodo changed the base branch from develop to refactor/move-account-vuex-state-to-composable September 29, 2023 07:43
@konradodo konradodo force-pushed the feat/removing-fungibleTokens-from-store branch 2 times, most recently from 7372e3a to 6cc42bd Compare September 29, 2023 10:31
peronczyk
peronczyk requested changes Sep 29, 2023
View reviewed changes
src/popup/App.vue Outdated Show resolved Hide resolved
peronczyk
peronczyk requested changes Sep 29, 2023
View reviewed changes
src/store/getters.js Outdated Show resolved Hide resolved
src/store/getters.js Outdated Show resolved Hide resolved
src/store/getters.js Outdated Show resolved Hide resolved
@konradodo konradodo force-pushed the feat/removing-fungibleTokens-from-store branch from 6cc42bd to aaa7204 Compare October 2, 2023 10:32
pstachel
pstachel reviewed Oct 3, 2023
View reviewed changes
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/composables/fungibleTokens.ts Outdated Show resolved Hide resolved
src/popup/components/Modals/ConfirmTransactionSign.vue Show resolved Hide resolved
src/popup/components/SwapRoute.vue Outdated Show resolved Hide resolved
src/popup/components/SwapRoute.vue Outdated Show resolved Hide resolved
src/popup/components/SwapRoute.vue Show resolved Hide resolved
@konradodo konradodo force-pushed the feat/removing-fungibleTokens-from-store branch 2 times, most recently from 171c96a to ced77e2 Compare October 3, 2023 11:47
@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch from fc1088e to e255040 Compare October 4, 2023 07:16
Base automatically changed from refactor/move-account-vuex-state-to-composable to develop October 4, 2023 11:02
@konradodo konradodo force-pushed the feat/removing-fungibleTokens-from-store branch 2 times, most recently from b038f92 to c3456e6 Compare October 5, 2023 08:11
@peronczyk peronczyk force-pushed the feat/removing-fungibleTokens-from-store branch 2 times, most recently from f90eecf to 3bacc38 Compare October 17, 2023 10:54
@peronczyk peronczyk force-pushed the feat/removing-fungibleTokens-from-store branch from 3bacc38 to 4680cb9 Compare October 23, 2023 11:14
@peronczyk peronczyk linked an issue Oct 23, 2023 that may be closed by this pull request
Move fungible tokens from Vuex to composable #2418
Closed
@peronczyk peronczyk force-pushed the feat/removing-fungibleTokens-from-store branch from 4680cb9 to a65630c Compare October 25, 2023 08:37
@peronczyk peronczyk force-pushed the feat/removing-fungibleTokens-from-store branch from a65630c to 401cb94 Compare October 25, 2023 12:59
CedrikNikita
CedrikNikita approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@CedrikNikita CedrikNikita left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable. Should be align with #2409 or vise verse, because the useAeSdk is no longer needed to use store on initialization. Didn't test it.

@peronczyk peronczyk merged commit e0c47db into develop Oct 26, 2023
4 checks passed
@peronczyk peronczyk deleted the feat/removing-fungibleTokens-from-store branch October 26, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peronczyk peronczyk peronczyk approved these changes

@CedrikNikita CedrikNikita CedrikNikita approved these changes

@pstachel pstachel pstachel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move fungible tokens from Vuex to composable
4 participants
@konradodo @peronczyk @CedrikNikita @pstachel