Allow ok/err/okAsync/errAsync to accept zero arguments when returning void #584
+16
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing a function returning a result, it's often that I need to construct an
Ok<void>
object. However, it's not so ergonomic to do this.ok
must be passed an argument, even if you explicitly specify thevoid
type. This leads to passing a "dummy" value:Meanwhile, in Promise-land, it's perfectly acceptable to call
Promise.resolve()
with no arguments, which returns aPromise<void>
.Interestingly, TS allows a parameter to be omitted if it has type
void
. However, this does not work if the type is generic and has been expanded tovoid
or a union containingvoid
. See microsoft/TypeScript#29131This PR adds additional overloads for
ok
,err
,okAsync
anderrAsync
that separate out the case where the argument type isvoid
. This allows the following to work as expected: