Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

betav9 fix #52

Merged
merged 2 commits into from
Apr 3, 2023
Merged

betav9 fix #52

merged 2 commits into from
Apr 3, 2023

Conversation

ElecTwix
Copy link
Contributor

@ElecTwix ElecTwix commented Apr 2, 2023 •
edited
Loading

Resp func modified.

After beta v9, lib is not working.
Removed Array checking.

#53

@ElecTwix
betav9 fix
6c3f70f 
resp func modifed.
@ElecTwix
lint fix
7777722
@ElecTwix
Copy link
Contributor Author

ElecTwix commented Apr 2, 2023

db.Create Not Generating Unique ID.

@ElecTwix ElecTwix mentioned this pull request Apr 2, 2023
Closed
@phughk phughk self-assigned this Apr 3, 2023
@phughk phughk mentioned this pull request Apr 3, 2023
Closed
@phughk
Copy link
Contributor

phughk commented Apr 3, 2023

Hey @ElecTwix thanks for this! Some tests needed changing so I fixed that up
#54
Please could you grab those changes? We can continue on your branch.

@phughk
Copy link
Contributor

phughk commented Apr 3, 2023

Actually will land both since they don't need to go in together

@phughk phughk mentioned this pull request Apr 3, 2023
Merged
phughk
phughk approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@phughk phughk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phughk phughk merged commit 9fb7511 into surrealdb:main Apr 3, 2023
@ElecTwix ElecTwix deleted the betav9 branch August 9, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phughk phughk phughk approved these changes

Assignees

@phughk phughk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElecTwix @phughk