POWERMON-306: fix wrong Prometheus rule reference for OTHER Power Consumption #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified the same on OpenShift
|
sthaha
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Thanks for the PR @vprashar2929 . Requesting changes to
- refer to the original issue being fixed in the commit msg
- remove backticks from commit message
…sumption This commit fixes the issue where the wrong Prometheus rule was referenced for displaying `OTHER Power Consumption(W) by Pods` in the dashboards Signed-off-by: vprashar2929 <[email protected]>
vprashar2929
force-pushed
the
fix-other-rule
branch
from
be227b4
to
14419d5
Compare
vprashar2929
changed the title
OTHER Power Consumption by Pods
sthaha
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue where the wrong Prometheus rule was referenced for displaying
OTHER Power Consumption(W) by Podsin the dashboard