fix: exit commands with non zero exit code if plan or apply fails (#1257

)

* fix: exit commands with non zero exit code if plan or apply fails

* refactor: refactor

* fix: return non zero if error is nil

pkg/apperr/error.go

@@ -62,14 +62,21 @@ func HandleExit(err error) int {
  logE := logrus.NewEntry(logrus.New())
 
  if exitErr, ok := err.(ExitCoder); ok { //nolint:errorlint
- if err.Error() != "" {
+ errMsg := err.Error()
+ if errMsg != "" {
  if _, ok := exitErr.(ErrorFormatter); ok {
  logrus.Errorf("%+v", err)
  } else {
  logerr.WithError(logE, err).Error("tfcmt failed")
  }
  }
- return exitErr.ExitCode()
+ if code := exitErr.ExitCode(); code != 0 {
+ return code
+ }
+ if errMsg == "" {
+ return ExitCodeOK
+ }
+ return ExitCodeError
  }
 
  logerr.WithError(logE, err).Error("tfcmt failed")

pkg/apperr/error_test.go

@@ -20,7 +20,7 @@ func TestHandleError(t *testing.T) {
  {
  name: "case 1",
  err: NewExitError(0, errors.New("error")),
- exitCode: 0,
+ exitCode: 1,
  },
  {
  name: "case 2",