Remove 'Update latest tag on published packages' step

[benmccann]

https://www.npmjs.com/package/@sveltejs/kit shows an old version of the README and people continually run into issues installing the latest instead of next package

[Rich-Harris]

is that just a matter of removing --tag=next from

kit/package.json

Line 12 in d1925cf

"release": "pnpm publish --tag=next --filter=\"@sveltejs/*\" --filter=\"create-svelte\""

? we can still stay in pre mode as far as changesets is concerned, and publish packages with a -next.n version suffix?

if so then 👍 this probably makes sense, though presumably we'd need to do some deprecated @next releases so that people are pointed towards latest? otherwise this would be equally confusing for the people currently using @next packages.

[pngwn]

We need to call changeset publish to get other tags and releases in the repo rather than recursively publishing manually.

[Rich-Harris]

but changeset publish would publish next tags because we're in prerelease mode, no? Will changeset publish respect the "private": true package.json fields?

[pngwn]

But changeset publish would publish next tags because we're in prerelease mode, no?

You're right, i'm not sure how we add additional tags for specific releases, I'll look into that.

Will changeset publish respect the "private": true package.json fields?

It will, yes.

[benmccann]

pnpm publish might not let us add two tags, but we should be able to add a second tag after the package is published

[dominikg]

we are using changeset publish and it is run by @changeset/action' here:

kit/.github/workflows/release.yml

Line 32 in 32a7ccf

- name: Create Release Pull Request or Publish to npm

This action emits outputs that could be used to generate
npm dist-tag add package@version latest calls in a conditional step

- name: Tag published packages as latest too
        if: steps.changesets.outputs.published == 'true'
        # somehow take that json output of steps.changesets.outputs.publishedPackages and turn it into dist-tag commands
        run: # execute commands

problems:

1. github actions expressions syntax is not a joy to work with
2. running dist-tag shortly after publishing a version for the first time may fail if the registry hasn't propagated the new version.

edit:
to avoid having to deal with the json in the action itself it could be passed back to a script that makes the calls

- name: Tag published packages as latest too
        if: steps.changesets.outputs.published == 'true'
        run: node /scripts/add-latest-tag.js '${{steps.changesets.outputs.publishedPackages}}'

[Rich-Harris]

Rather than close this and create another issue, I've renamed the title to remind us to remove this stuff once we exit pre:

kit/.github/workflows/release.yml

Lines 43 to 54 in f0df782

	- name: Update latest tag on published packages # only needed until we release 1.0.0 and exit pre-release mode
	if: steps.changesets.outputs.published == 'true'
	# wait a bit and then run "npm dist-tag add package@version latest" for all published packages
	env:
	NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
	published_packages: ${{steps.changesets.outputs.publishedPackages}}
	run: |
	sleep 20
	cat << EOF > "$HOME/.npmrc"
	//registry.npmjs.org/:_authToken=$NPM_TOKEN
	EOF
	echo $published_packages | jq -r 'map((.name + "@" + .version)) | .[]' | while read pkgver; do npm dist-tag add $pkgver latest || continue;done

[didier]

@Rich-Harris Can we close this?

[dummdidumm]

Yes we can :)