Skip Vite resolve workaround on Vite 4.1+ or Svelte 4+

[benmccann]

according to @dominikg:

latest vite does not need the custom resolve for it in v-p-s anymore, but early vite 4 versions did

I think we can safely remove this. People who are on old versions of Vite 4 may get larger apps if they upgrade vite-plugin-svelte without upgrading Vite, but that's relatively safe as nothing will break.

There's some nice benefits to removing this including simplifying the vite-plugin-svelte code and eventually paving the way for us to stop exporting svelte/ssr in Svelte core

[dominikg]

This requires a changeset and is a breaking change as we would have to bump the peer dependency on vite.

Another option would be to import and test the vite version so we only keep doing it for the early vite-4 versions. That would then be a patch

[dominikg]

Addendum: If you remove the svelte/ssr export that contains the onMount as noop, the feature would stop working altogether.

[benmccann]

I can't currently run pnpm changeset, but will generate a changeset after #623 is merged.

I don't think it's a breaking change because nothing breaks if this is removed. The user just ends up with a slightly larger bundle, but that doesn't seem breaking to me.

Removing svelte/ssr would be breaking. I think the sooner we get this change in the better so that one day in the future when we do decide we want to remove svelte/ssr most users will have upgraded this library already.

[dominikg]

slightly larger could be significantly larger and drive an edge deployment over a limit. I am not willing to take that risk.
If you want the standard resolve to be preferred, it would have to be with a major or fallback code for older vite-4

[benmccann]

fallback code for older vite-4

Do you know what version of Vite 4 this was fixed in or have a link to the issue this was working around? I wouldn't know where to start looking

[bluwy]

It's fixed in vitejs/vite#11595, which is released in Vite 4.1

[benmccann]

I've updated this to only do the resolve workaround on Vite 4.0

[benmccann]

I updated this to check the Svelte version as well