Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open link keystroke fails to activate on nonexistent links due to when expression #127

Closed
darbaga opened this issue Sep 24, 2020 · 1 comment
Closed

Open link keystroke fails to activate on nonexistent links due to when expression #127

darbaga opened this issue Sep 24, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@darbaga
Copy link

darbaga commented Sep 24, 2020

The open link command, if invoked by a keystroke on a link that does not yet have a corresponding file, fails to execute due to the refUnderCursorExists constraint. If the command is ran manually (through the command pallet) it runs fine.

I'm not very experienced with the vscode extension API, but my suspicion is is it fails because getRefUriUnderCursor only looks through existing files for references. The actual file creation happens in openDocumentByReference.

I'd be willing to do a PR, but I don't really know what needs changing. If you want a PR, give me some pointers on how this needs to be fixed and I'll try.
svsool added a commit that referenced this issue Sep 27, 2020
@svsool
Merge pull request #130 from bs/master
139fce6 
fix: Remove requirement `refUnderCursorExists` when using keyboard shortcut to follow a link #127
@svsool svsool added bug Something isn't working good first issue Good for newcomers labels Sep 27, 2020
@svsool
Copy link
Owner

svsool commented Sep 27, 2020

Thanks for reporting!

It was fixed in #130 by @bs (thanks for contribution ❤️) and will be released today.

@svsool svsool closed this as completed Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svsool @darbaga