Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: markdown file embedding #3

Closed
alexisargyris opened this issue Jul 7, 2020 · 8 comments
Closed

feature request: markdown file embedding #3

alexisargyris opened this issue Jul 7, 2020 · 8 comments
Assignees
Labels
feature New feature or request

Comments

@alexisargyris
Copy link

I understand that for the time being Memo can only embed image files. Being able to embed one markdown file into another would be very useful in order to introduce structure to a set of notes. Do you think that such a feature may be included in the roadmap?

@svsool
Copy link
Owner

svsool commented Jul 7, 2020

Hello,

I had this in mind and it sounds like a good feature to have. I tried to come up with something and here is what I got so far:

Embedding files.md
image

Features embedded.md
image

Preview of Embedding files.md

image

What do you think?

Still need to figure out what to do with cyclic links 🙂 .

@alexisargyris
Copy link
Author

This is perfect as far as I'm concerned. A way to adjust how the embedded file is displayed (e.g. via CSS like Obsidian does?) may also prove useful. As far as cyclic links are concerned maybe you could use something like a counter to check how many levels of embedding have happened and stop the process after a reasonable number of times? Thanks!

@svsool
Copy link
Owner

svsool commented Jul 8, 2020

A way to adjust how the embedded file is displayed (e.g. via CSS like Obsidian does?) may also prove useful.

You can do it already in VSCode out of the box. I haven't tried myself though.

https://code.visualstudio.com/docs/languages/markdown

image

I figured the solution for cyclic links.

Now I think if preview on hover should support embedded markdown or not, basically VSCode does not provide anything other than markdown support in hover popups and I guess embedding markdown into markdown might be looking not that cool as it looks with html in built-in preview.

@alexisargyris alexisargyris reopened this Jul 9, 2020
@alexisargyris
Copy link
Author

ok, I installed v0.1.6 and I see this:

embedding

What am I missing?

@svsool
Copy link
Owner

svsool commented Jul 9, 2020

hey, v0.1.6 does not include that feature yet, only this #4

@alexisargyris
Copy link
Author

ok, I'll wait for that to be released in order to have a look at the css. Thanks

svsool added a commit that referenced this issue Jul 10, 2020
svsool added a commit that referenced this issue Jul 10, 2020
@svsool
Copy link
Owner

svsool commented Jul 13, 2020

Hello!

You can test out markdown embedding feature in v0.1.8 along with other improvements.

Remember to reload VSCode window on updating from marketplace.

@svsool svsool closed this as completed Jul 13, 2020
@alexisargyris
Copy link
Author

works great!

@svsool svsool added the feature New feature or request label Jul 18, 2020
@svsool svsool self-assigned this Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants