Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support for '.' in links #346

Closed
Hocnonsense opened this issue Apr 27, 2021 · 5 comments
Closed

Feature request: Support for '.' in links #346

Hocnonsense opened this issue Apr 27, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@Hocnonsense
Copy link

I think . is not always at the end of a work. For example, a file is named version0.0.1.md can never be recognized. However, if it is created and maintained by other programs, I cannot rename it manually. Also, it is impossible to link a norm with . like tar.gz.

I guess it is caused by forward searching of .. If so, is it possible to find it reversely? To think more bravely, if there is a text file or any other format, we can use ![[filename.extention]] to show its content. In general, it is worth to be fixed!

Similar request:

Thanks!

@svsool
Copy link
Owner

svsool commented Apr 27, 2021

Hi, thanks for filing an issue.

Would you like to contribute?

@Hocnonsense
Copy link
Author

I'm looking at the code, but I think I'm not familiar with TS...

I notice it is not easy as I found this:

https:/svsool/vscode-memo/blob/62dda4d452ba908d37b280cede7c235abce5569a/src/utils/utils.ts#L95

@svsool
Copy link
Owner

svsool commented Apr 27, 2021

btw tar.gz shouldn't be a problem it just not amongst recognized formats, formats are whitelisted for perf reasons to scan less files on initial load.

Also reverse search already in use with known extensions as you mentioned so the problem is different in this case.

@svsool
Copy link
Owner

svsool commented Apr 27, 2021

should be fixed for long links in v0.3.7, short links worked as expected

@svsool svsool closed this as completed Apr 27, 2021
@svsool svsool added the bug Something isn't working label Apr 27, 2021
@Hocnonsense
Copy link
Author

Thanks! It did work! Grateful for your help 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants