Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: links to PDFs and other documents by filename #7

Closed
sahil48 opened this issue Jul 11, 2020 · 6 comments
Closed

Feature Request: links to PDFs and other documents by filename #7

sahil48 opened this issue Jul 11, 2020 · 6 comments
Assignees
Labels
feature New feature or request

Comments

@sahil48
Copy link

sahil48 commented Jul 11, 2020

Similar to images, please allow PDFs and other references to be referred to in the ![[filename.ext]] syntax

@svsool
Copy link
Owner

svsool commented Jul 13, 2020

Hi,

Support for embedding markdown files was released today in v0.1.8 version, so you can test it out by updating Memo via the marketplace.

About PDF support, how important is it for you to support PDF and what are the use cases? Embedding PDF requires additional effort to make the built-in Markdown preview work. As far as I know, WebKit allows you to embed PDF into HTML page, but it's a very basic PDF viewer, and you can't expect decent UX that some well-known PDF viewers / editors usually provide.

@sahil48
Copy link
Author

sahil48 commented Jul 13, 2020

I was simply hoping that selecting the PDF or word document would open it in the default application for further editing. An embedded document viewer is not necessary, just the ability to open it from the link entered in the markdown file.

@svsool
Copy link
Owner

svsool commented Jul 13, 2020

Alright, I started to think about "embedding" because you mentioned this ![[filename.ext]] syntax with ! in the beginning which is used for embedding files instead of [[filename.ext]] which is used for linking them 🙂 . I'll check if VSCode allows opening links in the default editor.

@ghost
Copy link

ghost commented Jul 15, 2020

Not sure if this fits OPs request, but I keep PDFs in my project folder, open them with the vscode-pdf extension, and then comment on them. My use-case is academia, i.e. citations and annotations.

[My hope is to be able to use memo (or foam) and create a perfect good enough work-flow to efficiently chew through PDFs and create my own Zettelkasten. memo has the better features (imo), but i am missing some graph visualization.]

@svsool
Copy link
Owner

svsool commented Jul 16, 2020

Not sure if this fits OPs request, but I keep PDFs in my project folder, open them with the vscode-pdf extension, and then comment on them. My use-case is academia, i.e. citations and annotations.

[My hope is to be able to use memo (or foam) and create a perfect good enough work-flow to efficiently chew through PDFs and create my own Zettelkasten. memo has the better features (imo), but i am missing some graph visualization.]

Thanks for mentioning vscode-pdf extension, it changed my mind a bit about how this feature can be used, so I'm going to implement a feature for opening any link to the existing file in the default app via additional command, otherwise on cmd + click / enter file will be opened in VSCode and displayed via supported plugins such as vscode-pdf.

@svsool svsool added the feature New feature or request label Jul 18, 2020
@svsool svsool self-assigned this Jul 18, 2020
@svsool
Copy link
Owner

svsool commented Jul 23, 2020

v0.1.9 should support Open link in the default app command. Also new document formats including pdf were added to autocomplete results.

Opening links in the default app

@svsool svsool closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants