refactor: Rename getConfigProperty -> getMemoConfigProperty

svsool · Sep 19, 2020 · 6ebf5cf · 6ebf5cf
1 parent 67ae66c
commit 6ebf5cf
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/src/features/BacklinksTreeDataProvider.spec.ts b/src/features/BacklinksTreeDataProvider.spec.ts
@@ -10,7 +10,7 @@ import {
  getWorkspaceFolder,
  toPlainObject,
  updateMemoConfigProperty,
- getConfigProperty,
+ getMemoConfigProperty,
 } from '../test/testUtils';
 
 const getChildren = async () => {
@@ -387,7 +387,7 @@ describe('BacklinksTreeDataProvider', () => {
 
  await window.showTextDocument(doc);
 
- expect(getConfigProperty('backlinksPanel.collapseParentItems', null)).toBe(false);
+ expect(getMemoConfigProperty('backlinksPanel.collapseParentItems', null)).toBe(false);
 
  expect((await getChildren()).every((child) => child.collapsibleState === 2)).toBe(true);
  });

diff --git a/src/features/BacklinksTreeDataProvider.ts b/src/features/BacklinksTreeDataProvider.ts
@@ -8,7 +8,7 @@ import {
  getWorkspaceFolder,
  trimSlashes,
  sortPaths,
- getConfigProperty,
+ getMemoConfigProperty,
 } from '../utils';
 import { FoundRefT } from '../types';
 
@@ -58,7 +58,7 @@ export default class BacklinksTreeDataProvider implements vscode.TreeDataProvide
  return [];
  }
 
- const collapsibleState = getConfigProperty('backlinksPanel.collapseParentItems', false)
+ const collapsibleState = getMemoConfigProperty('backlinksPanel.collapseParentItems', false)
  ? vscode.TreeItemCollapsibleState.Collapsed
  : vscode.TreeItemCollapsibleState.Expanded;
 

diff --git a/src/features/ReferenceHoverProvider.ts b/src/features/ReferenceHoverProvider.ts
@@ -7,7 +7,7 @@ import {
  containsUnknownExt,
  containsOtherKnownExts,
  getWorkspaceCache,
- getConfigProperty,
+ getMemoConfigProperty,
  getReferenceAtPosition,
  isUncPath,
  findUriByRef,
@@ -39,7 +39,7 @@ export default class ReferenceHoverProvider implements vscode.HoverProvider {
 
  if (foundUri && fs.existsSync(foundUri.fsPath)) {
  const imageMaxHeight = Math.max(
- getConfigProperty('linksOnHoverPreview.imageMaxHeight', 200),
+ getMemoConfigProperty('linksOnHoverPreview.imageMaxHeight', 200),
  10,
  );
  const getContent = () => {

diff --git a/src/test/testUtils.ts b/src/test/testUtils.ts
@@ -12,11 +12,11 @@ const {
  getImgUrlForMarkdownPreview,
  getFileUrlForMarkdownPreview,
  escapeForRegExp,
- getConfigProperty,
+ getMemoConfigProperty,
 } = utils;
 
 export {
- getConfigProperty,
+ getMemoConfigProperty,
  getWorkspaceFolder,
  getImgUrlForMarkdownPreview,
  getFileUrlForMarkdownPreview,

diff --git a/src/utils/utils.spec.ts b/src/utils/utils.spec.ts
@@ -23,7 +23,7 @@ import {
  normalizeSlashes,
  getWorkspaceFolder,
  getWorkspaceCache,
- getConfigProperty,
+ getMemoConfigProperty,
  matchAll,
  cacheWorkspace,
  cacheUris,
@@ -819,13 +819,13 @@ describe('getWorkspaceFolder()', () => {
  });
 });
 
-describe('getConfigProperty()', () => {
+describe('getMemoConfigProperty()', () => {
  it('should return config property', () => {
- expect(getConfigProperty('linksOnHoverPreview.imageMaxHeight', null)).toBe('200');
+ expect(getMemoConfigProperty('linksOnHoverPreview.imageMaxHeight', null)).toBe('200');
  });
 
  it('should return default property on getting unknown config property', () => {
- expect(getConfigProperty('unknownProperty', 'default')).toBe('default');
+ expect(getMemoConfigProperty('unknownProperty', 'default')).toBe('default');
  });
 });
 

diff --git a/src/utils/utils.ts b/src/utils/utils.ts
@@ -230,7 +230,7 @@ export const cleanWorkspaceCache = () => {
 export const getWorkspaceFolder = (): string | undefined =>
  vscode.workspace.workspaceFolders && vscode.workspace.workspaceFolders[0].uri.fsPath;
 
-export function getConfigProperty<T>(property: string, fallback: T): T {
+export function getMemoConfigProperty<T>(property: string, fallback: T): T {
  return vscode.workspace.getConfiguration().get(`memo.${property}`, fallback);
 }