Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Added javax.validation.Valid annotation to modules/swagger-codegen/… #6398

Merged
merged 6 commits into from
Sep 3, 2017

Conversation

carnevalegiacomo
Copy link
Contributor

@carnevalegiacomo carnevalegiacomo commented Aug 29, 2017

Java jaxrs-spec - javax.validation and interfaceOnly parameter management

  • Added javax.validation.Valid annotation to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/bodyParams.mustache
  • Added bean validation and api description to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/headerParams.mustache
  • Added api description to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/queryParams.mustache
  • Added interfaceOnly parameter management to modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavaJAXRSSpecServerCodegen.java to generate only interfaces and models.
  • Added interfaceOnly parameter management to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/api.mustache
  • Added throws java.lang.Exception to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/api.mustache

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master for non-breaking changes and 3.0.0 branch for breaking (non-backward compatible) changes.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

…src/main/resources/JavaJaxRS/spec/bodyParams.mustache

- Added bean validation and api description to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/headerParams.mustache
- Added api description to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/queryParams.mustache
- Added interfaceOnly parameter management to modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavaJAXRSSpecServerCodegen.java to generate only interfaces and models.
- Added interfaceOnly parameter management to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/api.mustache
- Added throws java.lang.Exception to modules/swagger-codegen/src/main/resources/JavaJaxRS/spec/api.mustache
@wing328
Copy link
Contributor

wing328 commented Aug 31, 2017

@carnevalegiacomo thanks for the PR. Please also run ./bin/jaxrs-spec-petstore-server.sh to update the Petstore sample.

@carnevalegiacomo
Copy link
Contributor Author

./bin/jaxrs-spec-petstore-server.sh done: a88e97a

@wing328 wing328 merged commit a1c1a82 into swagger-api:master Sep 3, 2017
@wing328
Copy link
Contributor

wing328 commented Sep 3, 2017

@carnevalegiacomo thanks for the enhancement, which has been merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants