feat: support swagger configuration #46
Conversation
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 1 1
Lines 34 34
=======================================
Hits 32 32
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
easonlin404
changed the title
|
please DONOT merge, I will add testings. |
easonlin404
changed the title
|
Destructive change, is it okay? |
| // WrapHandler wraps `http.Handler` into `gin.HandlerFunc`. | ||
| func WrapHandler(h *webdav.Handler) gin.HandlerFunc { | ||
| func WrapHandler(config *Config, h *webdav.Handler) gin.HandlerFunc { |
There was a problem hiding this comment.
It seems safer to prepare another function.
There was a problem hiding this comment.
I think feel good is revert and create another function.
There was a problem hiding this comment.
I am syncing up with swag code. sorry about bother.
There was a problem hiding this comment.
I see.
I was concerned about was the impact on users already using WrapHander .
So I think create another interface. eg: config setable and default config (WrapHander) .
There was a problem hiding this comment.
You're right for api backward compatibility. could you help add this feat?
There was a problem hiding this comment.
OK I do it.
Before that, I would like to revert this PR once to minimize the impact.
now URL variable can be set.
address swaggo/swag#194