Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix too many return values(#103) #105

Merged
merged 1 commit into from
Apr 30, 2018
Merged

fix too many return values(#103) #105

merged 1 commit into from
Apr 30, 2018

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Apr 29, 2018

for #103

@codecov-io
Copy link

codecov-io commented Apr 29, 2018

Codecov Report

Merging #105 into master will increase coverage by 0.54%.
The diff coverage is 79.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   86.01%   86.56%   +0.54%     
==========================================
  Files           5        5              
  Lines         758      759       +1     
==========================================
+ Hits          652      657       +5     
+ Misses         65       62       -3     
+ Partials       41       40       -1
Impacted Files Coverage Δ
schema.go 100% <ø> (ø) ⬆️
property.go 80% <76.92%> (+11.25%) ⬆️
parser.go 81.96% <80.39%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d83e9...841c275. Read the comment docs.

@easonlin404 easonlin404 self-requested a review April 30, 2018 02:02
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 95ee221 into swaggo:master Apr 30, 2018
@pei0804 pei0804 deleted the fix-103 branch April 30, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants