add support uuid and special type. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 86.63% 86.55% -0.08%
==========================================
Files 5 5
Lines 763 766 +3
==========================================
+ Hits 661 663 +2
Misses 62 62
- Partials 40 41 +1
Continue to review full report at Codecov.
|
This was referenced May 5, 2018
easonlin404
requested changes
May 5, 2018
property.go
Outdated
| } | ||
|
|
||
| fmt.Printf("%s is not supported. but It is set with string temporary. Please report any problems.\n", astTypeSelectorExpr.Sel.Name) | ||
| return propertyName{SchemaType: "string", ArrayType: "string"} | ||
| } |
There was a problem hiding this comment.
please use fmt.Printf("%s is not supported. but it will be set with string temporary. Please report any problems.", astTypeSelectorExpr.Sel.Name).
easonlin404
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #110
close #109
There is a limit to individual correspondence.
I decided to interpret unknown types as strings.
But UUID is popular. So I add supecial support.