Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Decimal and ptr slice #113

Merged
merged 1 commit into from
May 9, 2018
Merged

Add support Decimal and ptr slice #113

merged 1 commit into from
May 9, 2018

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented May 8, 2018

for #112

@pei0804 pei0804 changed the title Add support Decimal and ptr slice [WIP]Add support Decimal and ptr slice May 8, 2018
@codecov-io
Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #113 into master will increase coverage by 0.55%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   86.55%   87.11%   +0.55%     
==========================================
  Files           5        5              
  Lines         766      776      +10     
==========================================
+ Hits          663      676      +13     
+ Misses         62       60       -2     
+ Partials       41       40       -1
Impacted Files Coverage Δ
property.go 83.72% <83.33%> (+4.93%) ⬆️
parser.go 82.75% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0bccab...dda444c. Read the comment docs.

@pei0804 pei0804 changed the title [WIP]Add support Decimal and ptr slice Add support Decimal and ptr slice May 9, 2018
@easonlin404 easonlin404 self-requested a review May 9, 2018 02:00
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants