Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add octet-stream mimetype #127

Merged
merged 1 commit into from
May 17, 2018
Merged

add octet-stream mimetype #127

merged 1 commit into from
May 17, 2018

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented May 17, 2018

Describe the PR
close #126

@pei0804 pei0804 mentioned this pull request May 17, 2018
Closed
@codecov-io
Copy link

codecov-io commented May 17, 2018 •
edited
Loading

Codecov Report

Merging #127 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage    87.6%   87.66%   +0.06%     
==========================================
  Files           5        5              
  Lines         807      811       +4     
==========================================
+ Hits          707      711       +4     
  Misses         60       60              
  Partials       40       40
Impacted Files Coverage Δ
operation.go 91.54% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d0221...1b1217a. Read the comment docs.

mancioshell
mancioshell approved these changes May 17, 2018
View reviewed changes
Copy link

@mancioshell mancioshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank You 👍

easonlin404
easonlin404 approved these changes May 17, 2018
View reviewed changes
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@easonlin404 easonlin404 merged commit 1dfbfbc into master May 17, 2018
@easonlin404 easonlin404 deleted the add-126 branch May 24, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mancioshell mancioshell mancioshell approved these changes

@easonlin404 easonlin404 easonlin404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support application/octet-stream Mime Type
4 participants
@pei0804 @codecov-io @mancioshell @easonlin404