Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support externalDocs annotation comment #1468

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Support externalDocs annotation comment #1468

merged 3 commits into from
Feb 16, 2023

Conversation

ikrisliu
Copy link
Contributor

Describe the PR
Support externalDocs annotation comment.

Relation issue
#470

@ubogdan
Copy link
Contributor

ubogdan commented Feb 14, 2023

Can you add unit tests to cover the newly added code?

Readme should also be updated so new users will discover this feature easily

@ikrisliu
Copy link
Contributor Author

Can you add unit tests to cover the newly added code?

Readme should also be updated so new users will discover this feature easily

Done

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 85.14% // Head: 85.18% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (e835e89) compared to base (aa3e8d5).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head e835e89 differs from pull request most recent head 3d9890b. Consider uploading reports for the commit 3d9890b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
+ Coverage   85.14%   85.18%   +0.03%     
==========================================
  Files          19       19              
  Lines        3616     3624       +8     
==========================================
+ Hits         3079     3087       +8     
  Misses        459      459              
  Partials       78       78              
Impacted Files Coverage Δ
parser.go 94.50% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrisliu Thanks for your contribution

@ubogdan ubogdan merged commit 37f466e into swaggo:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants